Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golangci-lint version mismatch between Makefile and Github Build action #624

Closed
eromanova opened this issue Nov 12, 2024 · 1 comment · Fixed by #620
Closed

Golangci-lint version mismatch between Makefile and Github Build action #624

eromanova opened this issue Nov 12, 2024 · 1 comment · Fixed by #620
Assignees
@eromanova

Comments

@eromanova
Copy link
Member

eromanova commented Nov 12, 2024 •
edited
Loading

Currently, our Makefile pins the golangci-lint version to v1.61.0. However, in the GitHub build action (golangci/golangci-lint), the latest linter version is used (currently v1.62.0). With the linter of v1.62.0 version, the max-public-structs linter shows a false-positive result. There is an inconsistency between the linter run locally and in the build job.
@eromanova eromanova self-assigned this Nov 12, 2024
@eromanova eromanova changed the title Golangci linter version mismatch in the Makefile and github build action Golangci-lint version mismatch between Makefile and Github Build action Nov 12, 2024
This was referenced Nov 12, 2024
Merged
Merged
@eromanova eromanova moved this from Todo to In Progress in Project 2A Nov 12, 2024
@eromanova
Copy link
Member Author

Related issue: mgechev/revive#1103.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Project 2A Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eromanova eromanova

Labels
None yet
Projects
Project 2A
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use linter from makefile target in the build workflow eromanova/hmc
1 participant
@eromanova