Use linter from makefile target in the build workflow #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kshatrix
previously approved these changes
Nov 11, 2024
eromanova
force-pushed
the
linter-version
branch
2 times, most recently
from
63327e3 to
0e64f26
Compare
eromanova
force-pushed
the
linter-version
branch
5 times, most recently
from
48ca784 to
318cfb1
Compare
eromanova
force-pushed
the
linter-version
branch
from
318cfb1 to
8519e44
Compare
By default, the linter uses the latest version (currently v1.62.0). In v1.62.0, a new max-public-structs linter was added. Significant changes are required in our codebase to enable this linter.
eromanova
force-pushed
the
linter-version
branch
from
8519e44 to
19b58b6
Compare
eromanova
changed the title
|
I disabled the |
|
mgechev/revive#1103 related issue. |
Kshatrix
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
golangci/golangci-lint-actionuses the latest linter version (currently v1.62.0). With the linter of v1.62.0 version, themax-public-structslinter shows a false-positive result.Currently, in our Makefile, we have the linter version pinned to
v1.61.0. This PR ensures consistency by aligning the linter version in the GitHub Actions workflow with the version used in the Makefile (which is used locally).Closes #624