-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uncork max message size #22
Comments
FWIW I tried using this fix locally and even with this in place the connection breaks when setting the max message size to above 65,535 bytes (breaks = client sends handshake to host, host receives handshake and sends one to client, client never receives the handshake back) |
miwarnec
pushed a commit
that referenced
this issue
Nov 28, 2021
…based on receive window size. #22 skywind3000/kcp#291
miwarnec
pushed a commit
that referenced
this issue
Nov 28, 2021
…based on receive window size. #22 skywind3000/kcp#291
fixed on master! |
miwarnec
pushed a commit
to MirrorNetworking/Mirror
that referenced
this issue
Nov 28, 2021
- uncorks max message size from 144 KB to as much as we want based on receive window size. fixes MirrorNetworking/kcp2k#22 fixes skywind3000/kcp#291 - feature: OnData now includes channel it was received on - fixes #2989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
see paul's kcp PR for possible fix.
-> we use the configured window sizes anyway
-> the limit on max message size is artificial
-> some people do like to send larger messages
The text was updated successfully, but these errors were encountered: