Endpoint configuration with warning #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes EndpointConfiguration configurable this, primarily, enables for creation of Private API Gateway Endpoints, ones only accessible from within a VPC. It is an attempt to address: #1540 See also: https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-private-apis.html
1 similar comment
|
s/Ivan/Ilya d: 👍 on addressing concerns raised by @gpkc |
|
@IlyaSukhanov I am the worst, was talking to my roommate from college (Ivan) at the same time as doing this PR and autopiloted. My apologies, man! |
|
All cool! Thank you. |
fbidu
reviewed
May 4, 2019
| @@ -1389,12 +1392,58 @@ Like API Gateway, Zappa can automatically provision ALB resources for you. You' | |||
| // And here, a list of security group IDs, eg. 'sg-fbacb791' | |||
| ] | |||
| } | |||
| ``` | |||
There was a problem hiding this comment.
The deletion of this line broke the next session of the readme. The sessions Endpoint Configuration and Example Private API Gateway configuration are being displayed as part of this block of code.
Since this was already merged, I'll open a new issue & PR fixing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per @IlyaSukhanov's work in #1719, this adds an option within settings to tweak an API Gateway's endpoint configuration, which allows for creation of private APIGW endpoints.
One note; due to the nature of private endpoints, a status code can't be retrieved on
zappa deployorzappa update, so a warning message is shown to the user instead indicating to double-check the success of their deployment.GitHub Issues
#1540