Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ZIP permissions when building on Windows #716

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

schlarpc
Copy link
Contributor

This change puts the correct permission bits into the packaged ZIP even if the filesystem doesn't support Unix permissions (e.g. Windows). Also, the previous behavior of setting external_attr on the ZipFile object had no effect as the property is non-existent.

Description

GitHub Issues

This change puts the correct permission bits into the packaged ZIP even if the filesystem doesn't support Unix permissions (e.g. Windows). Also, the previous behavior of setting external_attr on the ZipFile object had no effect as the property is non-existent.
@coveralls
Copy link

coveralls commented Mar 13, 2017

Coverage Status

Coverage increased (+0.02%) to 80.247% when pulling ad1df40 on schlarpc:patch-1 into e498538 on Miserlou:master.

@Miserlou
Copy link
Owner

I think this is okay, I don't have a Windows machine to test one.

Thanks for your contribution! In future, please open a ticket before filing a PR and include a link to that ticket in the code's comment, as per the Contributing guide.

@Miserlou Miserlou merged commit c2fa6da into Miserlou:master Mar 13, 2017
@mcrowson mcrowson mentioned this pull request Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants