Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/Include six #994

Closed
wants to merge 1 commit into from
Closed

fix/Include six #994

wants to merge 1 commit into from

Conversation

jakul
Copy link
Contributor

@jakul jakul commented Jul 5, 2017 •
edited
Loading

Description

This PR fixes #845 by including six in the uploaded Lambda. The original problem is that deploying on Python 3.6 gives the following error ImportError: No module named six.moves.http_client

Miserlou said that the inclusion of six was the problem in psf/requests#3985 (comment)

GitHub Issues

#845

@coveralls
Copy link

coveralls commented Jul 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 73.295% when pulling b112427 on jakul:patch-1 into b7c16d3 on Miserlou:master.

@Miserlou
Copy link
Owner

Miserlou commented Jul 5, 2017

But you've only changed the code if if sys.version_info[0] < 3:..?

@jakul
Copy link
Contributor Author

jakul commented Jul 6, 2017

Oops.

@jakul jakul closed this Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportError: No module named six.moves.http_client
3 participants
@jakul @coveralls @Miserlou