Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #82: ignoring network_id if using Basic networking #133

Closed

Conversation

nicolasbrechet
Copy link
Contributor

Network ID shouldn't be used with Basic Networking, so if we're using Basic Networking and a network_id is set, we should just ignore it.

This should not change anything if Advanced Networking is used, or if no network ID is set when using Basic Networking.

… Basic Networking and a network_id is set, we should just ignore it.
@miguelaferreira
Copy link
Contributor

Hi @nicolasbrechet

Thanks for the PR.
@bheuvel found a way to query the needed information for network type and security groups from the cloud itself (using the fog library).

Could you please test his PR (#134) to see if his solution will fix the problem you found?

@miguelaferreira
Copy link
Contributor

Closing this PR since it has been addressed in PR #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants