Fix launchd plist config to remove daemonization. #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure the CI failures are not related to the changes in this PR. |
|
Looks like a failed download. Can you rerun ci? |
It's a valid error zlib.net removed the 1.2.12 release (404 response). Let me see if I can upgrade to 1.2.13. |
jshort
force-pushed
the
launchctl_fix
branch
2 times, most recently
from
8cce3ea
to
e7dba2e
Compare
|
Hmmm, we need to update vcpck microsoft/vcpkg#27271 |
For launchd to properly manage the process you do *not* want to daemonize and bg the process otherwise launchd 'loses' the process. After loading the plist, `sudo launchd list` now shows the et server service with the correct pid and unloading the server kills the process(es).
vcpkg now downloads zlib from github rather than zlib.net and this should fix the issues of version tarballs being removed from zlib.net and causing download 404s.
vcpkg now downloads zlib from github rather than zlib.net and this |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For launchd to properly manage the process you do not want to daemonize and bg the process otherwise launchd 'loses' the process.
After loading the plist,
sudo launchd listnow shows the et server service with the correct pid and unloading the server kills the process(es).