Parse telemetry ini config as boolean and make telemetry opt-in. #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In issue MisterTea#504, it was brought to attention that while the command line arg for enabling telemetry was boolean, the ini config in et.cfg needed to be an int to change the value. SimpleIni has a GetBoolValue function that treats the strings "0", "off", "no", "false" as boolean false and "1", "on", "true" as boolean true. Also, this will make telemetry opt-in as opposed to opt-out as has been requested by multiple users. The supplied et.cfg file will still have telemetry on.
Codecov ReportBase: 70.75% // Head: 71.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
==========================================
+ Coverage 70.75% 71.21% +0.45%
==========================================
Files 49 49
Lines 3074 3074
==========================================
+ Hits 2175 2189 +14
+ Misses 899 885 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I'd say this has baked long enough without disagreement, merging... |
jshort
added a commit
to jshort/EternalTerminal
that referenced
this pull request
May 2, 2024
In addition to opt-in for telemetry (see MisterTea#553) this uses the log directory override from MisterTea#556 to place the sentry/telemetry logs.
jshort
added a commit
to jshort/EternalTerminal
that referenced
this pull request
May 2, 2024
In addition to opt-in for telemetry (see MisterTea#553) this uses the log directory override from MisterTea#556 to place the sentry/telemetry logs.
MisterTea
pushed a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #504, it was brought to attention that while the command line arg for enabling telemetry was boolean, the ini config in et.cfg needed to be an int to change the value. SimpleIni has a GetBoolValue function that treats the strings "0", "off", "no", "false" as boolean false and "1", "on", "true" as boolean true.
Also, this will make telemetry opt-in as opposed to opt-out as has been requested by multiple users. The supplied et.cfg file will still have telemetry on.