-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell support (config, CI action to detect new typos) + fix some typos #605
Conversation
=== Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #605 +/- ##
==========================================
- Coverage 73.47% 73.02% -0.45%
==========================================
Files 50 50
Lines 3042 3051 +9
==========================================
- Hits 2235 2228 -7
- Misses 807 823 +16
☔ View full report in Codecov by Sentry. |
Hey, I'm not sure why we are failing the clang-format test now, but can you fix those before merging? |
I will submit later pr without changes to check if that check is green on general - https://github.com/MisterTea/EternalTerminal/actions/workflows/clang-format-check.yml shows that last time it was ran was 2 months ago, so may be just some new version of tooling causes it now to fail, not that changes in this pr |
Clang-format is right here, extra letter made |
…despell === Do not change lines below === { "chain": [], "cmd": "clang-format -i src/terminal/TelemetryService.cpp", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
thanks, pushed results of |
Thanks! |
No description provided.