Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress counter-intuitive behavior when providing extract function. #2374

Closed
wants to merge 2 commits into from
Closed

Suppress counter-intuitive behavior when providing extract function. #2374

wants to merge 2 commits into from

Conversation

Hugo-Trentesaux
Copy link

Providing a custom extract function was preventing the promise rejection, which is counter-intuitive. Propose changing that.

@dead-claudia
Copy link
Member

Please make sure to search the issues first before suggesting features. If you still feel strongly about it, please file a new issue, so we can discuss it first - this isn't a small fix or addition.

For reference, the current behavior was requested in #2000 and implemented in #2006.

@Hugo-Trentesaux
Copy link
Author

OK, thanks for the explanation and sorry for not having looked deeper in it.
I think the promise should be rejected only when an error is thrown upon it's resolution. Then even without extract function provided, the status code could not lead to promise rejection.
Do you want me to open an issue about this ?

@dead-claudia
Copy link
Member

@Hugo-Trentesaux

Do you want me to open an issue about this ?

Feel free to. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants