Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Istanbul to kill install warnings #2979

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

dead-claudia
Copy link
Member

Description

Title's pretty self-explanatory. Also, this isn't really used much in practice.

Motivation and Context

From a local run:

$ npm ci
npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead     
d
npm warn deprecated istanbul@0.4.5: This module is no longer maintained, try this instead:
npm warn deprecated   npm i nyc
npm warn deprecated Visit https://istanbul.js.org/integrations for other alternatives.

added 239 packages, and audited 240 packages in 9s

42 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

How Has This Been Tested?

npm install after the patch:

$ npm i

up to date, audited 212 packages in 2s

42 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@dead-claudia dead-claudia requested a review from a team as a code owner September 26, 2024 04:03
@dead-claudia dead-claudia merged commit e15602b into MithrilJS:main Sep 26, 2024
7 checks passed
@dead-claudia dead-claudia deleted the drop-istanbul branch September 26, 2024 04:05
@JAForbes JAForbes mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant