m.domFor(): workaround for unintentional mangling. Fix #2842 #2981
+7
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of domFor() for the internal bundler.
Description
#2842 appears to be caused by a combination of the mangling of the internal bundler and the parameter destructuring of domFor().
mithril.js/mithril.js
Line 157 in cfa890f
This pr avoids the parameter destructuring to fix the issue.
Motivation and Context
fix #2842
How Has This Been Tested?
Observing behavior of reproduction codes on the flems (#2842 (comment)) by replacing with the generated mithril.(min.)js.
Of course,
npm run test
has passed.Types of changes
Checklist