Skip to content

Commit

Permalink
fix: git node metadata arg passing (nodejs#500)
Browse files Browse the repository at this point in the history
  • Loading branch information
codebytere authored Sep 12, 2020
1 parent 0d347f8 commit 55c780e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion components/git/land.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const { parsePRFromURL } = require('../../lib/links');
const getMetadata = require('../metadata');
const { getMetadata } = require('../metadata');
const CLI = require('../../lib/cli');
const Request = require('../../lib/request');
const { runPromise } = require('../../lib/run');
Expand Down
4 changes: 2 additions & 2 deletions components/git/metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const yargs = require('yargs');

const { parsePRFromURL } = require('../../lib/links');
const getMetadata = require('../metadata');
const { getMetadata } = require('../metadata');
const CLI = require('../../lib/cli');
const config = require('../../lib/config').getMergedConfig();
const { runPromise, IGNORE } = require('../../lib/run');
Expand Down Expand Up @@ -80,7 +80,7 @@ function handler(argv) {
const cli = new CLI(logStream);

const merged = Object.assign({}, argv, parsed, config);
return runPromise(getMetadata(merged, cli)
return runPromise(getMetadata(merged, false, cli)
.then(({ status }) => {
if (status === false) {
throw new Error(IGNORE);
Expand Down
4 changes: 3 additions & 1 deletion components/metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const MetadataGenerator = require('../lib/metadata_gen');

const fs = require('fs');

module.exports = async function getMetadata(argv, skipRefs, cli) {
async function getMetadata(argv, skipRefs, cli) {
const credentials = await auth({
github: true,
jenkins: true
Expand Down Expand Up @@ -49,3 +49,5 @@ module.exports = async function getMetadata(argv, skipRefs, cli) {
checker
};
};

module.exports = { getMetadata };

0 comments on commit 55c780e

Please sign in to comment.