Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Keep A Changelog" version detection #16

Merged

Conversation

marcusrbrown
Copy link
Contributor

This builds off the work in #11 by detecting the "Keep A Changelog" version block using the version specified in package.json. In my project, my CHANGELOG.md is formatted as follows:

# Changelog

...

## [Unreleased]

...

## [0.1.2] - 2018-01-20

...

[Unreleased]: [...]
[0.1.2]: [...]
...

Without this patch, github-release-from-changelog will start the change block at ## [Unreleased] even though the version is "0.1.2" in package.json. The patch will also end change block detection at the first line beginning with "[", which assumes that the line begins a block of links in the footer of the changelog.

@MoOx MoOx merged commit b96ea68 into MoOx:master Jan 22, 2018
@MoOx
Copy link
Owner

MoOx commented Jan 22, 2018

Awesome! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants