Wrap defines #250
Merged
Wrap defines #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilenns
commented
Jun 29, 2023
Comment on lines
73
to
75
| #define STEPS 64 | ||
| #define STEPPER_SPEED 400 // 300 already worked, 467, too? | ||
| #define STEPPER_ACCEL 800 |
There was a problem hiding this comment.
I didn't wrap these because I don't think they are used? I need to open a separate issue for it, they only exist in the nano and uno MFBoard.h files.
There was a problem hiding this comment.
define STEPS 64 is indeed not used, but STEPPER_SPEED and STEPPER_ACCEL is used in MFStepper.cpp.
But we could think about to move it to the MFStepper.h file as it is more related to the stepper as to the boards and the speed and acceleration can be set by the connector now.
|
Firmware for this pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249
Description of changes
Add
#ifndefaround all of the defines in the MFBoard.h files. Doesn't result in any change in functionality, just enables setting them via environment variables in the future.