Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on out-of-bounds in digInMux #257

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

elral
Copy link
Collaborator

@elral elral commented Aug 25, 2023

Description of changes

In the for loop the array digInMux[] gets not exceeded anymore as i is used instead ofdigInMuxRegistered for the array index.

Fixes #255

@elral elral requested a review from DocMoebiuz as a code owner August 25, 2023 09:09
@github-actions
Copy link

Firmware for this pull request:
Firmware.zip

@elral elral requested a review from GioCC August 25, 2023 11:15
Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! What an error :D

@DocMoebiuz DocMoebiuz merged commit 71d439e into MobiFlight:main Sep 5, 2023
1 check passed
@elral elral deleted the Exceeding_Array_255 branch September 8, 2023 08:05
@elral elral restored the Exceeding_Array_255 branch September 8, 2023 08:05
@elral elral deleted the Exceeding_Array_255 branch September 8, 2023 08:05
@DocMoebiuz DocMoebiuz added the bug Something isn't working label Nov 6, 2023
@DocMoebiuz DocMoebiuz changed the title Fixed exceeding digInMux array Fix crash on out-of-bounds in digInMux Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearing DigInMux can lead to a crash
2 participants