Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write eeprom or name if they are available even config is in flash #333

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

elral
Copy link
Collaborator

@elral elral commented Sep 5, 2024

Description of changes

In addition to PR #327 fully backwards compatibility is now ensured.
Once a config is in EEPROM, this config can still be changed even a config is in flash.
Once a name is in EEPROM, this name can still be changed even a config is in flash.
If no name and no config is in EEPROM, name and config can not be changed anymore.

Copy link

github-actions bot commented Sep 5, 2024

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

Copy link

github-actions bot commented Sep 5, 2024

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

Copy link

github-actions bot commented Sep 7, 2024

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

Copy link

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only small notes and a question which use case that is where it can be

if (configStoredInEEPROM() || !configStoredInFlash())

src/Config.cpp Show resolved Hide resolved
src/Config.cpp Outdated Show resolved Hide resolved
src/Config.cpp Outdated Show resolved Hide resolved
src/Config.cpp Show resolved Hide resolved
src/Config.cpp Show resolved Hide resolved
Copy link

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

Copy link

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

@DocMoebiuz DocMoebiuz merged commit 018fe51 into MobiFlight:main Sep 30, 2024
1 check passed
@elral elral deleted the fix_config_early_merge branch October 1, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants