Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: app-extension code sign and auto signature/provisioning profile pickup #293

Merged
merged 5 commits into from
May 19, 2018
Merged

fixed: app-extension code sign and auto signature/provisioning profile pickup #293

merged 5 commits into from
May 19, 2018

Conversation

dkimitsa
Copy link
Contributor

this PR contains two related to each-other parts:

  1. it fixes auto signature/provisioning profile pickup as it was broken when was trying to pickup signature -- it resulted in random first one that matches iPhone Developer|iOS Development and often it doesn't match profile
  2. fix for code-sign of app-extension: it is required to embed own extension provisioning profile and entitlements
  3. provisioning profile is auto picked up but config was extended to allow custom profile to be specified for extension:
<appExtensions>
    <extension profile="3AED05A9-5F1F-4120-9276-11980B9C88EE">OneSignalNotificationServiceExtension</extension>
</appExtensions>

@dkimitsa
* fixed: auto signature/provisioning profile pick/up:
531aa4c 
Old code was broken due following: if signature was set to 'Auto' it was picking any `iPhone Developer|iOS Development` one without any respect to provisioning profile. This caused following use cases broken:
1. `auto signature` and `manual profile`: randomly picked signature will not match profile (in case you are not lucky and have lot of signatures/profiles);
2. `auto signature` and `auto profile` will not work as well as signature is random;

Fix provides following:
1. `auto signature` and `manual profile`: picks only signatures that matches profile;
2. `auto signature` and `auto profile`: first set of profiles that match bundle id is fetched. This set is being intersected with list of identities to find a profile and signature pair that matches each other.
@dkimitsa
* fixed: auto signature/provisioning profile pick/up (continued to IO…
ea70289 
…STarget)

* app-extension fixed to add own provision profile and embed entitlements into signature
@dkimitsa
Copy link
Contributor Author

lets wait for confirmation from @sofroma

@dkimitsa
Copy link
Contributor Author

long read https://dkimitsa.github.io/2018/05/16/fix-app-ext-autoprofile-bro-gen/

@dkimitsa
Copy link
Contributor Author

3rd commit copies support files needed for stickers app ext, check gitter message for details.

@dkimitsa
Copy link
Contributor Author

as per @sofroma comment it is working now and can be reviewed

@florianf florianf merged commit d5029b4 into MobiVM:master May 19, 2018
@dkimitsa dkimitsa deleted the appext_appstore_fix branch May 23, 2018 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkimitsa @florianf