Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class paths for JVM languages other than Java. #316

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

clydebarrow
Copy link
Contributor

Replicates behaviour of Robovm gradle plugin. Without this patch, Kotlin classes either do not compile during build (e.g. for application class) or are not found at run time.

Replicates behaviour of Robovm gradle plugin.
@florianf
Copy link
Collaborator

florianf commented Jul 7, 2018

Thanks for the PR!
@dkimitsa can you take a look at it? seems o.k. to me.
Related to #264

@dkimitsa
Copy link
Contributor

dkimitsa commented Jul 7, 2018

personaly i dont like such workarounds without finding rootcase of issue. but seems today we have to go this way till idea fixes facet issue. one thing i would like to see here is proper decorations with comments to have it explained what is going on there

@florianf florianf merged commit 2de696d into MobiVM:master Jul 9, 2018
@florianf
Copy link
Collaborator

florianf commented Jul 9, 2018

@clydebarrow Thanks for the PR. Could you please check if this resolves #264 ?

@dkimitsa thanks for the looks. I think the code is generally understandable.

@clydebarrow
Copy link
Contributor Author

@florianf Yes, it resolves #264 .

dkimitsa pushed a commit to dkimitsa/robovm that referenced this pull request Jan 3, 2019
Replicates behaviour of Robovm gradle plugin.

(cherry picked from commit 2de696d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants