debugger maintaince (2020) #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…herwise breakpoint in one line loops will not fire while stepping. Code sample while(true) foo(); // breakpoint here
…at were instrumented with hooks and where breakpoint can be set. This improves usability and IDE will mark breakpoint as invalid if debugger can't stop there. To support this bptable now filled with values, where bits set to 1 (bp enabled) at lines that not being instrumented. during runtime this will not have affect as there was not hook code injected for these lines, but debugger will read bptable from executable to find out what lines are available
…top in dalvik.*, libcore.* classes when stepping. user might disable these settings in preferences.
…k stack as these provide no information or source code location
…lasses configured to be ignored (this class was picked as target for back stack and then event was dropped and not delivered to JDWP client)
|
details with images in post |
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 9, 2020
* * breakpoints should be checked before spepping (even if stepping) otherwise breakpoint in one line loops will not fire while stepping. Code sample while(true) foo(); // breakpoint here * * debugger: fixed bug when debugger was crashing on resolving Thread objects * * debugger: method line table handler updated to return only lines that were instrumented with hooks and where breakpoint can be set. This improves usability and IDE will mark breakpoint as invalid if debugger can't stop there. To support this bptable now filled with values, where bits set to 1 (bp enabled) at lines that not being instrumented. during runtime this will not have affect as there was not hook code injected for these lines, but debugger will read bptable from executable to find out what lines are available * * debugger: adding to debugger stepping configuration filter to not stop in dalvik.*, libcore.* classes when stepping. user might disable these settings in preferences. * debugger: added filter to skip synthetic bridges and callbacks in back stack as these provide no information or source code location * * debugger: fixed not working step-out in case back stack contained classes configured to be ignored (this class was picked as target for back stack and then event was dropped and not delivered to JDWP client)
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 9, 2020
* * breakpoints should be checked before spepping (even if stepping) otherwise breakpoint in one line loops will not fire while stepping. Code sample while(true) foo(); // breakpoint here * * debugger: fixed bug when debugger was crashing on resolving Thread objects * * debugger: method line table handler updated to return only lines that were instrumented with hooks and where breakpoint can be set. This improves usability and IDE will mark breakpoint as invalid if debugger can't stop there. To support this bptable now filled with values, where bits set to 1 (bp enabled) at lines that not being instrumented. during runtime this will not have affect as there was not hook code injected for these lines, but debugger will read bptable from executable to find out what lines are available * * debugger: adding to debugger stepping configuration filter to not stop in dalvik.*, libcore.* classes when stepping. user might disable these settings in preferences. * debugger: added filter to skip synthetic bridges and callbacks in back stack as these provide no information or source code location * * debugger: fixed not working step-out in case back stack contained classes configured to be ignored (this class was picked as target for back stack and then event was dropped and not delivered to JDWP client)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dalvik.*,libcore.*