fixed #561: reverted binding of structs with flexible array members #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible by applying @array({1}) annotations. This will return pointer to member. When it was annotated as `@ByVal` it was returning a copy of struct. And setting items to copy would cause memory corruption
|
few comments why struct binding are messing in post |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #561 was introduced during ios13 binding generation.
Root case
To work with Flexible Array Members (FAM) its required to get pointer to the member and then navigate by it to put/get data.
When struct member is annotated as
@ByValit will return a COPY of first element of FAM instead of pointer to it.Updating this element as array will not affect original struct (the issue itself) and is dangerous as will produce memory corruption if items changed at index 1+