Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle plugin not working on Gradle 7 #590

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

Anuken
Copy link
Contributor

@Anuken Anuken commented Jun 25, 2021

This is a tiny change that fixes a build error that occurs when the RoboVM Gradle plugin is run with Gradle 7.

A sample error:

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':ios:createIPA' (type 'ArchiveTask').
  - Type 'org.robovm.gradle.tasks.ArchiveTask' property 'roboVMLogger' is missing an input or output annotation.
    
    Reason: A property without annotation isn't considered during up-to-date checking.
    
    Possible solutions:
      1. Add an input or output annotation.
      2. Mark it as @Internal.
    
    Please refer to https://docs.gradle.org/7.0.2/userguide/validation_problems.html#missing_annotation for more details about this problem.

As the logger is neither an input nor an output, I chose the second solution.

Copy link

@tommyettinger tommyettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward. As long as Internal is available with Gradle 6, I don't see an issue. It really is a tiny change, and it seems necessary.

@Anuken
Copy link
Contributor Author

Anuken commented Jun 25, 2021

It looks like @Internal was added in 3.0, so this should be safe to add. I've tested this change in my project and it definitely fixes the error.

Copy link
Contributor

@dkimitsa dkimitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, look ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants