* fixed: in case of simulator, embedded frameworks/dylibs were stripped for not required arches #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tripped due wrong condition ## Root case its regression after M1 support: `.isArm()` doesn't mean device target anymore, to filter out simulator `environment` check to be done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root case
its a regression after M1 support:
.isArm()doesn't mean device target anymore, to filter out simulatorenvironmentcheck to be doneother moment
currently compiler will try to copy swift dynamic libraries but these lack
arm64-simulatorslice andarch stripwill fail that block launch on simulator. described behaviour is an another issue itself -- we should not try to copy swift dylibs in case ofarm64-simulatorbut its to be provided as standalone PR