* fixed: gradle plugin failed to be deployed #780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it discovered a set of issue:
Issue 1. plugin wasn't deployed in several last builds from master branch.
fix: annotation was removed (method doesn't look as pure getter) and
validatePlugins
option was added to build invocationIssue 2. its discovered that after #766 applied build failed with:
root case of it:
robovm-compiler
dependency was excluded from shadowJar (thats a bug). But it was working as previously pom.xml contained runtime dependency torobovm-compiler
(that's another bug as we produce shadowJar with merged dependencies)Issue 3: pom.xml for gradle plugin is empty
it happens as
plugin-publish
usespluginMaven
publication but we set metadata formavenJava
, due another bug bothpluginMaven
andmavenJava
are being deployed andpluginMaven
overrides first (thats another issues)Issue 4: two artifacts are being deployed under same id:
pluginMaven
andmavenJava
it can be observer as following warning:
Fixes:
mavenJava
to be removed andpluginMaven
used as described inplugin-publish
docs;Caused by: java.lang.NoClassDefFoundError: org/robovm/compiler/log/Logger
is fixed by removing 'exclude(dependency' -- compiler has to be packed into shadowJar