Add validation error support

Signed-off-by: Bartosz Polaczyk <polac24@gmail.com>
MobileNativeFoundation · Jan 25, 2022 · 5ac2d21 · 5ac2d21
1 parent a46e94c
commit 5ac2d21
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/Sources/XCLogParser/activityparser/ActivityParser.swift b/Sources/XCLogParser/activityparser/ActivityParser.swift
@@ -524,7 +524,7 @@ public class ActivityParser {
         }
         switch token {
         case .string(let string):
-            return string
+            return string.trimmingCharacters(in: .whitespacesAndNewlines)
         case .null:
             return ""
         default:

diff --git a/Sources/XCLogParser/extensions/ArrayExtension.swift b/Sources/XCLogParser/extensions/ArrayExtension.swift
@@ -50,7 +50,8 @@ extension Array where Element: Notice {
             $0.type == .clangError ||
             $0.type == .linkerError ||
             $0.type == .packageLoadingError ||
-            $0.type == .scriptPhaseError
+            $0.type == .scriptPhaseError ||
+            $0.type == .failedCommandError
         }
     }
 

diff --git a/Sources/XCLogParser/parser/BuildStep.swift b/Sources/XCLogParser/parser/BuildStep.swift
@@ -85,6 +85,12 @@ public enum DetailStepType: String, Encodable {
     /// For steps that are not a detail step
     case none
 
+    /// Validate watch, extensions binaries
+    case validateEmbeddedBinary
+
+    /// Validate app
+    case validate
+
     // swiftlint:disable:next cyclomatic_complexity
     public static func getDetailType(signature: String) -> DetailStepType {
         switch signature {
@@ -118,7 +124,12 @@ public enum DetailStepType: String, Encodable {
             return .swiftAggregatedCompilation
         case Prefix("PrecompileSwiftBridgingHeader "):
             return .precompileBridgingHeader
+        case Prefix("ValidateEmbeddedBinary "):
+            return .validateEmbeddedBinary
+        case Prefix("Validate "):
+            return .validate
         default:
+            print(signature)
             return .other
         }
     }

diff --git a/Sources/XCLogParser/parser/NoticeType.swift b/Sources/XCLogParser/parser/NoticeType.swift
@@ -62,6 +62,9 @@ public enum NoticeType: String, Codable {
     /// Error running a Build Phase's script
     case scriptPhaseError
 
+    /// Failed command error (e.g. ValidateEmbeddedBinary, CodeSign)
+    case failedCommandError
+
     // swiftlint:disable:next cyclomatic_complexity
     public static func fromTitle(_ title: String) -> NoticeType? {
         switch title {
@@ -89,6 +92,8 @@ public enum NoticeType: String, Codable {
             return .scriptPhaseError
         case Prefix("error: Swiftc"):
             return .swiftError
+        case Suffix("failed with a nonzero exit code"):
+            return .failedCommandError
         default:
             return .note
         }