Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanups pre 12.5 #495

Merged
merged 2 commits into from
Jun 19, 2021
Merged

Small cleanups pre 12.5 #495

merged 2 commits into from
Jun 19, 2021

Conversation

ob
Copy link
Member

@ob ob commented Jun 16, 2021

This is a small clean-up so that #491 is smaller.

It just removes some unnecessary imports, and replaces a call to popen() with NSTask

ob added 2 commits June 16, 2021 16:50
I was getting this error when running locally:

Failed to open macho file at /usr/bin/nm for reading: Too many levels of symbolic links

and it only happens with the `popen()` for swift. Since we use runShell
for objective C right below, make the calls match.

Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Remove unneeded headers
Clean up the interfaces to BPTestBundleConnection and
BPTestDaemonConnection

Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
@ob ob force-pushed the ob/small-cleanup-pre-12.5 branch from 9468b9f to 95e469d Compare June 16, 2021 23:51
Copy link

@shepting shepting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ob ob changed the title Small cleanup pre 12.5 Small cleanups pre 12.5 Jun 19, 2021
@ob ob merged commit b4b8344 into master Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants