Keep parenthesis in Swift tests #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
One way XCTest differentiates between Swift and Objective-C tests is by the parenthesis at the end of the name. I can't remember why we were stripping them, but I suspect it was for aesthetic reasons. Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
chenxiao0228
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #492, it essentially implements approach number one detailed there, keeping the parenthesis in Swift test names. See #492 for details of why this is needed.
It also includes some warning fixes and updates the deployment target to macOS 10.15.