Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xcode 13 support #500

Merged
merged 6 commits into from
Sep 29, 2021
Merged

Add Xcode 13 support #500

merged 6 commits into from
Sep 29, 2021

Conversation

dusi
Copy link
Contributor

@dusi dusi commented Jun 30, 2021

Just an attempt to add Xcode 13 support ¯_(ツ)_/¯

@ravimandala ravimandala requested a review from ob July 1, 2021 18:56
@ravimandala ravimandala mentioned this pull request Jul 1, 2021
@ravimandala ravimandala requested a review from chenxiao0228 July 1, 2021 21:32
@ravimandala ravimandala self-assigned this Jul 1, 2021
Copy link
Contributor

@ravimandala ravimandala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but can we wait until final GM is available?

.github/workflows/PR.yml Outdated Show resolved Hide resolved
.github/workflows/PR.yml Outdated Show resolved Hide resolved
.github/workflows/PR.yml Outdated Show resolved Hide resolved
.github/workflows/PR.yml Outdated Show resolved Hide resolved
.github/workflows/master.yml Outdated Show resolved Hide resolved
.github/workflows/master.yml Outdated Show resolved Hide resolved
.github/workflows/master.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ravimandala ravimandala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make a pre-release or beta release named v5.10.0-beta with this change.

Copy link
Contributor

@ravimandala ravimandala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dusi Can you please update README.md like this PR did?

ravimandala
ravimandala previously approved these changes Aug 25, 2021
Copy link
Contributor

@ravimandala ravimandala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pavel Dusatko and others added 4 commits September 21, 2021 10:17
Signed-off-by: Pavel Dusatko <pdusatko@slack-corp.com>
Signed-off-by: Pavel Dusatko <pdusatko@slack-corp.com>
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Signed-off-by: Ravi Mandala <rmandala@linkedin.com>
ob
ob previously approved these changes Sep 28, 2021
Copy link
Member

@ob ob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Signed-off-by: Ravi Mandala <rmandala@linkedin.com>
@ravimandala
Copy link
Contributor

@ob Since the reporting tests with diagnostics are taking a really long time and timing out some executions, I split a test and turned diagnostics on a simpler Timeout+Crash test case. Please take a look and re-bless the PR. Thanks.

ob
ob previously approved these changes Sep 28, 2021
…archive size

Signed-off-by: Ravi Mandala <rmandala@linkedin.com>
Copy link
Member

@ob ob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find, lgtm!

@ravimandala ravimandala merged commit 01259e0 into MobileNativeFoundation:master Sep 29, 2021
@ravimandala
Copy link
Contributor

Thanks @dusi for taking the initiative and adding the Xcode 13 support. 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants