-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xcode 13 support #500
Add Xcode 13 support #500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but can we wait until final GM is available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make a pre-release or beta release named v5.10.0-beta with this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dusi Can you please update README.md
like this PR did?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Pavel Dusatko <pdusatko@slack-corp.com>
Signed-off-by: Pavel Dusatko <pdusatko@slack-corp.com>
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Signed-off-by: Ravi Mandala <rmandala@linkedin.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Signed-off-by: Ravi Mandala <rmandala@linkedin.com>
@ob Since the reporting tests with diagnostics are taking a really long time and timing out some executions, I split a test and turned diagnostics on a simpler Timeout+Crash test case. Please take a look and re-bless the PR. Thanks. |
…archive size Signed-off-by: Ravi Mandala <rmandala@linkedin.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice find, lgtm!
Thanks @dusi for taking the initiative and adding the Xcode 13 support. 🥇 |
Just an attempt to add Xcode 13 support ¯_(ツ)_/¯