Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spaces from scheme names in fixtures #485

Merged
merged 1 commit into from
May 31, 2022
Merged

Remove spaces from scheme names in fixtures #485

merged 1 commit into from
May 31, 2022

Conversation

brentleyjones
Copy link
Contributor

This works around bazelbuild/bazel#4327.

@brentleyjones brentleyjones requested a review from cgrindel May 31, 2022 18:52
@brentleyjones
Copy link
Contributor Author

Needed for #484.

cgrindel
cgrindel approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@cgrindel cgrindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is such a pain. Perhaps we should push on getting this fixed in Bazel

@brentleyjones
Copy link
Contributor Author

Seems like bazelbuild/bazel#14676 would fix it?

@brentleyjones brentleyjones merged commit a38a691 into main May 31, 2022
@brentleyjones brentleyjones deleted the bj/remove-fixture-sxcheme-spaces branch May 31, 2022 19:26
@cgrindel
Copy link
Contributor

Agreed. That is what I meant to say. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrindel cgrindel cgrindel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentleyjones @cgrindel