Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PopularInCategoryModel fails to fit second time #162

Closed
blondered opened this issue Jul 13, 2024 · 0 comments · Fixed by #163
Closed

PopularInCategoryModel fails to fit second time #162

blondered opened this issue Jul 13, 2024 · 0 comments · Fixed by #163
Assignees
@blondered
Labels
bug Something isn't working

Comments

@blondered
Copy link
Collaborator

What happened?

    category_feature='genre',
    n_categories=5,
    popularity="mean_weight",
    mixing_strategy="group",
    ratio_strategy="proportional",)
pop_cat.fit(dataset)
pop_cat.fit(dataset)``` fails with TypeError

`cross_validate` fails with the same error

### Expected behavior

No errors :)

### Relevant logs and/or screenshots

_No response_

### Operating System

macOS Big Sur 11.6 (Apple M1)

### Python Version

any

### RecTools version

0.6.0
@blondered blondered added the bug Something isn't working label Jul 13, 2024
@blondered blondered moved this to 🏗 In progress in RecTools board Jul 13, 2024
@blondered blondered self-assigned this Jul 13, 2024
@blondered blondered mentioned this issue Jul 16, 2024
Merged
@blondered blondered moved this from 🏗 In progress to 👀 In review in RecTools board Jul 16, 2024
blondered added a commit that referenced this issue Jul 16, 2024
@blondered
Fix/pop in cat refit (#163)
374b4ae 
- Fixed `PopularInCategoryModel` refit behaviour and `cross-validate`
compatibility
- Fixed `PopularInCategoryModel` empty category interactions behaviour
- Added tests
Closes #162
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in RecTools board Jul 16, 2024
blondered added a commit that referenced this issue Sep 23, 2024
@blondered
Fix/pop in cat refit (#163)
d3d6bb6 
- Fixed `PopularInCategoryModel` refit behaviour and `cross-validate`
compatibility
- Fixed `PopularInCategoryModel` empty category interactions behaviour
- Added tests
Closes #162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blondered blondered

Labels
bug Something isn't working
Projects
RecTools board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/pop in cat refit MobileTeleSystems/RecTools
1 participant
@blondered