Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ease #107

Merged
merged 16 commits into from
Mar 11, 2024
Merged

Feature/ease #107

merged 16 commits into from
Mar 11, 2024

Conversation

In48semenov
Copy link
Collaborator

@In48semenov In48semenov commented Feb 26, 2024

Added EASE model (#91).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

rectools/models/ease.py Outdated Show resolved Hide resolved
rectools/models/ease.py Outdated Show resolved Hide resolved
@blondered blondered linked an issue Feb 26, 2024 that may be closed by this pull request
rectools/models/__init__.py Outdated Show resolved Hide resolved
rectools/models/ease.py Outdated Show resolved Hide resolved
rectools/models/ease.py Show resolved Hide resolved
rectools/models/ease.py Outdated Show resolved Hide resolved
rectools/models/rank.py Outdated Show resolved Hide resolved
rectools/models/rank.py Outdated Show resolved Hide resolved
rectools/models/rank.py Outdated Show resolved Hide resolved
rectools/models/rank.py Show resolved Hide resolved
In48semenov and others added 2 commits March 1, 2024 11:25
Co-authored-by: Daria <93913290+blondered@users.noreply.github.com>
Co-authored-by: Daria <93913290+blondered@users.noreply.github.com>
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (50af05f).
Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #107    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           45        51     +6     
  Lines         2242      2605   +363     
==========================================
+ Hits          2242      2605   +363     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@blondered blondered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are ready to merge this, just a few small last changes please :)

rectools/models/ease.py Outdated Show resolved Hide resolved
rectools/models/rank.py Outdated Show resolved Hide resolved
tests/models/test_rank.py Outdated Show resolved Hide resolved
tests/models/test_ease.py Outdated Show resolved Hide resolved
rectools/models/ease.py Outdated Show resolved Hide resolved
rectools/models/rank.py Outdated Show resolved Hide resolved
rectools/models/rank.py Outdated Show resolved Hide resolved
rectools/models/rank.py Outdated Show resolved Hide resolved
rectools/models/ease.py Outdated Show resolved Hide resolved
rectools/models/ease.py Outdated Show resolved Hide resolved
@In48semenov In48semenov marked this pull request as ready for review March 11, 2024 09:35
@blondered blondered merged commit f7aee48 into MobileTeleSystems:main Mar 11, 2024
9 checks passed
blondered pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EASE model
2 participants