Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/debias wrapper #152

Merged
merged 90 commits into from
Aug 5, 2024
Merged

Feature/debias wrapper #152

merged 90 commits into from
Aug 5, 2024

Conversation

In48semenov
Copy link
Collaborator

@In48semenov In48semenov commented Jun 6, 2024 •
edited by feldlime
Loading

Description

Added DebiasWrapper for metrics
Closes #98

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

Семенов Андрей Максимович and others added 28 commits March 29, 2024 18:17
Added v1 for DebiasWrapper
cff922f
Fixed copyright year
d068249
Added wrapper instanse for every ranking and cls metrics
aef087e
Renamed module for debias metrics
b63d4b7
@In48semenov
Merge branch 'MobileTeleSystems:main' into feature/debias_wrapper
f45f593
Added __new__ to DebiasWrapper and cls method
ac28756
Merge branch 'feature/debias_wrapper' of https://github.com/In48semen…
d7a8056 
…ov/RecTools into feature/debias_wrapper
Changed DebiasWrapper from class to function debias_wrapper, adde…
12d7a65 
…d `DebiasBase` to base.py
Fixed bugs in make_downsampling and added test for this method.
d11f002
Added test for calc debias metrics and fixed bugs.
37372f3
Added test for debias metric and fixed bugs
a8ff90f
Merge branch 'feature/debias_wrapper' of https://github.com/In48semen…
b72a086 
…ov/RecTools into feature/debias_wrapper
Fixed code style
cc04f96
Fixed code style.
c35b8f1
Fixed docs
faef485
Fixed
9fb5708
Fixed
d28a16e
Merge branch 'd28a16e' into feature/debias_wrapper
a6cb3ed
Changed DebiasWrapper from class to function debias_wrapper, adde…
92dc508 
…d `DebiasBase` to base.py
Fixed code style.
4590ccd
Fixed
27706a4
Fixed
a05d95f
Added DebiasConfig
cc4baf5
Removed unnecessary code, fixed fit method for MAP metric
aa80955
Fixed code style.
7f05256
Fixed bugs
72e538b
Fixed bugs.
8ee3d3a
Removed print
4d168c0
@In48semenov In48semenov self-assigned this Jun 6, 2024
feldlime
feldlime reviewed Jul 31, 2024
View reviewed changes
rectools/metrics/debias.py Outdated Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
blondered
blondered requested changes Aug 1, 2024
View reviewed changes
rectools/metrics/ranking.py Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
blondered
blondered requested changes Aug 1, 2024
View reviewed changes
rectools/metrics/debias.py Outdated Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
Семенов Андрей Максимович added 2 commits August 1, 2024 11:20
blondered
blondered reviewed Aug 2, 2024
View reviewed changes
rectools/metrics/classification.py Outdated Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
rectools/metrics/debias.py Outdated Show resolved Hide resolved
rectools/metrics/ranking.py Outdated Show resolved Hide resolved
rectools/metrics/ranking.py Outdated Show resolved Hide resolved
blondered
blondered previously approved these changes Aug 2, 2024
View reviewed changes
feldlime
feldlime requested changes Aug 4, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
rectools/metrics/auc.py Outdated Show resolved Hide resolved
rectools/metrics/auc.py Outdated Show resolved Hide resolved
rectools/metrics/auc.py Outdated Show resolved Hide resolved
rectools/metrics/auc.py Outdated Show resolved Hide resolved
tests/metrics/test_auc.py Outdated Show resolved Hide resolved
tests/metrics/test_auc.py Outdated Show resolved Hide resolved
tests/metrics/test_debias.py Outdated Show resolved Hide resolved
tests/metrics/test_scoring.py Outdated Show resolved Hide resolved
tests/metrics/test_scoring.py Outdated Show resolved Hide resolved
Семенов Андрей Максимович added 2 commits August 5, 2024 12:02
@feldlime feldlime merged commit ff38526 into MobileTeleSystems:main Aug 5, 2024
9 checks passed
@feldlime feldlime mentioned this pull request Aug 5, 2024
Closed
blondered pushed a commit that referenced this pull request Sep 23, 2024
@In48semenov
Feature/debias wrapper (#152)
4d94d8e 
Added DebiasWrapper for metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feldlime feldlime feldlime approved these changes

@blondered blondered blondered left review comments

Assignees

@In48semenov In48semenov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@In48semenov @feldlime @blondered