-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in MetricsApp's display() method #169
Merged
blondered
merged 12 commits into
MobileTeleSystems:main
from
Gooogr:fix/metricsapp_display
Aug 12, 2024
Merged
Fix error in MetricsApp's display() method #169
blondered
merged 12 commits into
MobileTeleSystems:main
from
Gooogr:fix/metricsapp_display
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 56 +11
Lines 2242 3446 +1204
===========================================
+ Hits 2242 3446 +1204 ☔ View full report in Codecov by Sentry. |
feldlime
reviewed
Jul 30, 2024
feldlime
reviewed
Aug 6, 2024
Co-authored-by: Emiliy Feldman <feldlime@yandex.ru>
feldlime
reviewed
Aug 7, 2024
blondered
reviewed
Aug 7, 2024
feldlime
approved these changes
Aug 12, 2024
blondered
pushed a commit
that referenced
this pull request
Sep 23, 2024
- Fixed `MetricsApp` `display` method - Added `nbformat` to dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
local variable fig_widget referenced before assignment
after callingdisplay()
method of MetricsApp instance.Type of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.