Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow warp-kos loss for LightFMWrapperModel #175

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

chezou
Copy link
Contributor

@chezou chezou commented Aug 10, 2024

Description

Fix #174

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
    • Yes
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
    • No
  • Does your change require any new tests?
    • Yes
  • Have you updated the changelog file?
    • Yes

I know it is the best unit test for it, but I gave up on finding the right dataset to successfully fit.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (8658b67).
Report is 70 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #175     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        56     +11     
  Lines         2242      3447   +1205     
===========================================
+ Hits          2242      3447   +1205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blondered blondered merged commit f73d054 into MobileTeleSystems:main Aug 13, 2024
9 checks passed
blondered pushed a commit that referenced this pull request Sep 23, 2024
- Fixed `NotImplementedError` for LightFM with warp-kos loss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightFMWrapperModel doesn't work with loss="warp-kos"
3 participants