Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/item net #191

Merged
merged 22 commits into from
Oct 1, 2024
Merged

Feature/item net #191

merged 22 commits into from
Oct 1, 2024

Conversation

In48semenov
Copy link
Collaborator

@In48semenov In48semenov commented Sep 19, 2024

Description

Added embeddings categorical item features to ItemNetBlock, Constructed Item Net for embeddings items ids and features. Also added method to retrieve categorical features from SparseFeatures.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

@In48semenov
Copy link
Collaborator Author

In48semenov commented Sep 19, 2024

TODO:

  • Tutorial notebook for SasRec model with categorical features
  • DocString

rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/dataset/features.py Outdated Show resolved Hide resolved
rectools/dataset/features.py Outdated Show resolved Hide resolved
rectools/dataset/features.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/dataset/features.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
rectools/models/sasrec.py Show resolved Hide resolved
rectools/models/sasrec.py Outdated Show resolved Hide resolved
@blondered
Copy link
Collaborator

We also need to update interface in example.ipynb before merge.

Семенов Андрей Максимович added 2 commits October 1, 2024 11:39
@blondered blondered marked this pull request as ready for review October 1, 2024 10:25
@blondered blondered merged commit 1700391 into experimental/sasrec Oct 1, 2024
7 checks passed
@blondered blondered deleted the feature/item_net branch October 1, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants