Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/epochs for als #203

Merged
merged 14 commits into from
Nov 11, 2024
Merged

Feature/epochs for als #203

merged 14 commits into from
Nov 11, 2024

Conversation

blondered
Copy link
Collaborator

Essential ImplicitALSWrapperModel refactoring for #176

@blondered
Copy link
Collaborator Author

@feldlime I Know we need to pass epochs for partial_fit method. But adding it to fit was the only way to run tests correctly.

I think we should move this argument to partial_fit in the next PR

@blondered blondered self-assigned this Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (fad48d3).
Report is 71 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #203     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        57     +12     
  Lines         2242      3758   +1516     
===========================================
+ Hits          2242      3758   +1516     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rectools/models/implicit_als.py Outdated Show resolved Hide resolved
rectools/models/implicit_als.py Show resolved Hide resolved
rectools/models/implicit_als.py Show resolved Hide resolved
rectools/models/implicit_als.py Outdated Show resolved Hide resolved
rectools/models/implicit_als.py Show resolved Hide resolved
tests/models/test_implicit_als.py Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
rectools/models/implicit_als.py Show resolved Hide resolved
@blondered blondered merged commit 11727d3 into main Nov 11, 2024
11 checks passed
@blondered blondered deleted the feature/epochs_for_als branch November 11, 2024 10:03
@chezou chezou mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants