Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit version update #45

Merged
merged 19 commits into from
Oct 4, 2023
Merged

Implicit version update #45

merged 19 commits into from
Oct 4, 2023

Conversation

blondered
Copy link
Collaborator

@blondered blondered commented Oct 2, 2023 •
edited
Loading

  • Bumped implicit version to 0.7.1
  • Updated implicit models wrappers and tests
  • Temporarily removed fitting_features_together=True support for ALS model

@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #45 (cec82e0) into main (9b3992e) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         2242      2212   -30     
=========================================
- Hits          2242      2212   -30
Files Coverage Δ
rectools/metrics/classification.py 100.00% <100.00%> (ø)
rectools/metrics/diversity.py 100.00% <100.00%> (ø)
rectools/models/dssm.py 100.00% <100.00%> (ø)
rectools/models/implicit_als.py 100.00% <100.00%> (ø)
rectools/models/implicit_knn.py 100.00% <100.00%> (ø)
rectools/utils/array_set_ops.py 100.00% <100.00%> (ø)
rectools/utils/indexing.py 100.00% <100.00%> (ø)
rectools/utils/misc.py 100.00% <100.00%> (ø)

feldlime
feldlime reviewed Oct 2, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
rectools/models/implicit_als.py Outdated Show resolved Hide resolved
rectools/models/implicit_knn.py Show resolved Hide resolved
feldlime
feldlime reviewed Oct 4, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Daria Tikhonovich and others added 4 commits October 4, 2023 13:19
feldlime
feldlime reviewed Oct 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tests/models/test_implicit_als.py Outdated Show resolved Hide resolved
tests/models/test_implicit_als.py Outdated Show resolved Hide resolved
@blondered blondered self-assigned this Oct 4, 2023
@blondered blondered merged commit 0fe1bc0 into main Oct 4, 2023
7 checks passed
@blondered blondered deleted the feature/update_implicit branch October 4, 2023 17:33
blondered added a commit that referenced this pull request Sep 23, 2024
@blondered
Implicit version update (#45)
c793c13 
- Bumped implicit version to 0.7.1
- Updated implicit models wrappers and tests
- Temporarily removed fitting_features_together=True support for ALS model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feldlime feldlime feldlime approved these changes

Assignees

@blondered blondered

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blondered @feldlime