Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/normalized_AvgRecPopularity #89

Merged
merged 12 commits into from
Mar 10, 2024

Conversation

mikesokolovv
Copy link
Collaborator

@mikesokolovv mikesokolovv commented Feb 21, 2024

Added normalize parameter to AvgRecPopularity

Соколов Михаил and others added 7 commits January 15, 2024 21:58
Co-authored-by: Соколов Михаил <mksokolov@mts.ru>
* optimization of calc_per_user method; tests added

* computations changed to vector form

---------

Co-authored-by: Соколов Михаил <mksokolov@mts.ru>
* calc_per_user update

---------

Co-authored-by: Соколов Михаил <mksokolov@mts.ru>
* arp calc_per_user updated; docstrings updated

---------

Co-authored-by: Соколов Михаил <mksokolov@mts.ru>
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (799ae8b).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #89    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           45        49     +4     
  Lines         2242      2549   +307     
==========================================
+ Hits          2242      2549   +307     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* pr num changed

---------

Co-authored-by: Соколов Михаил <mksokolov@mts.ru>
@blondered
Copy link
Collaborator

blondered commented Feb 21, 2024

Let's add math for normalized variant in the docstring. And also describe in words, what is the motivation to use normalized version of the metric.

@blondered blondered linked an issue Feb 26, 2024 that may be closed by this pull request
rectools/metrics/popularity.py Outdated Show resolved Hide resolved
rectools/metrics/popularity.py Outdated Show resolved Hide resolved
rectools/metrics/popularity.py Show resolved Hide resolved
tests/metrics/test_popularity.py Outdated Show resolved Hide resolved
rectools/metrics/popularity.py Outdated Show resolved Hide resolved
@mikesokolovv mikesokolovv merged commit 2676798 into MobileTeleSystems:main Mar 10, 2024
9 checks passed
@blondered blondered changed the title normalize parameter added to AvgRecPopularity metric feature/normalized_AvgRecPopularity Mar 11, 2024
blondered pushed a commit that referenced this pull request Sep 23, 2024
## Type of change

- [x] New feature (non-breaking change which adds functionality)

---------

Co-authored-by: Соколов Михаил <mksokolov@mts.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AverageRecommendationPopularity metric
2 participants