Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a custom rule to check conditional requirement of vehicle_types.json file presence #54

Closed
isabelle-dr opened this issue Nov 2, 2021 · 2 comments
Closed

Write a custom rule to check conditional requirement of vehicle_types.json file presence #54

isabelle-dr opened this issue Nov 2, 2021 · 2 comments
Labels
New rule

Comments

@isabelle-dr
Copy link
Contributor

The GBFS specification mentions the following in the vehicle_types.json file:

REQUIRED of systems that include information about vehicle types in the free_bike_status file. If this file is not included, then all vehicles in the feed are assumed to be non-motorized bicycles. This file SHOULD be published by systems offering multiple vehicle types for rental, for example pedal bikes and bikes.

A custom rule should be written to include this rule in the validator.

The additional context in:
@isabelle-dr isabelle-dr mentioned this issue Nov 2, 2021
Merged
@isabelle-dr
Copy link
Contributor Author

@PierrickP your ideas are welcome here :)

PierrickP added a commit that referenced this issue Nov 10, 2021
@PierrickP
Add conditional requirement
a0c3c1a 
On `free_bike_status.json`
+ `vehicle_type_id` if has a `vehicle_types.json`
+ `current_range_meters` if the vehicle_type_id has not the `human` propulsion

Set `vehicle_types.json` required if `free_bike_status.json` has `vehicle_type_id`

issue #54
@PierrickP PierrickP mentioned this issue Nov 10, 2021
Closed
@isabelle-dr isabelle-dr linked a pull request Nov 17, 2021 that will close this issue
Add conditional requirement #59
Closed
tdelmas pushed a commit to tdelmas/gbfs-validator that referenced this issue Feb 1, 2022
@PierrickP @tdelmas
Add conditional requirement
0ff7f7d 
On `free_bike_status.json`
+ `vehicle_type_id` if has a `vehicle_types.json`
+ `current_range_meters` if the vehicle_type_id has not the `human` propulsion

Set `vehicle_types.json` required if `free_bike_status.json` has `vehicle_type_id`

issue MobilityData#54
tdelmas added a commit to tdelmas/gbfs-validator that referenced this issue Feb 2, 2022
@tdelmas
Squashed 'gbfs-validator/versions/schemas/' changes from 4b1f5a4..90a…
4c0eb0c 
…6ec1

90a6ec1 Update README.md
c05169e Create README.md (MobilityData#64)
b871a0e Add GitHub Actions to validate schemas (MobilityData#54)
61c4de1 Fix invalid json, no trailing commas (MobilityData#63)

git-subtree-dir: gbfs-validator/versions/schemas
git-subtree-split: 90a6ec18bb7d23b5eba8e400b5df549d254e9fd2
@isabelle-dr
Copy link
Contributor Author

Closing, solved in #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
New rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add conditional requirement MobilityData/gbfs-validator
1 participant
@isabelle-dr