Fix vehicle_types.json wrongly required #85

[tdelmas]

Fix #85

• A station_id field on vehicles in free_bike_status.json will not mark vehicle_types.json anymore as required, as the spec doesn't require it.

Code cleaning:

• freeBikeStatusHasVehicleId var is renamed freeBikeStatusHasVehicleTypeId to better reflect what it check.

https://gbfs.nextbike.net/maps/gbfs/v2/nextbike_le/gbfs.json is not marked invalid anymore.

[netlify]

❌ Deploy Preview for competent-payne-690ca9 failed.

Name	Link
🔨 Latest commit	274582f
🔍 Latest deploy log	https://app.netlify.com/sites/competent-payne-690ca9/deploys/633d78320484090009bac58f

[netlify]

✅ Deploy Preview for gbfs-validator ready!

Name	Link
🔨 Latest commit	274582f
🔍 Latest deploy log	https://app.netlify.com/sites/gbfs-validator/deploys/633d7832d004790008acf68d
😎 Deploy Preview	https://deploy-preview-86--gbfs-validator.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[PierrickP]

Hello @nbdh can you test it ?

[netlify]

❌ Deploy Preview for wizardly-engelbart-5c48ca failed.

Name	Link
🔨 Latest commit	274582f
🔍 Latest deploy log	https://app.netlify.com/sites/wizardly-engelbart-5c48ca/deploys/633d7832ac34b600096903ae

[netlify]

❌ Deploy Preview for kind-pike-a3f3f8 failed.

Name	Link
🔨 Latest commit	274582f
🔍 Latest deploy log	https://app.netlify.com/sites/kind-pike-a3f3f8/deploys/633d783214c65900085f8aa3

[nbdh]

Hi @PierrickP,

I've checked https://deploy-preview-86--gbfs-validator.netlify.app/?url=https%3A%2F%2Fgbfs.nextbike.net%2Fmaps%2Fgbfs%2Fv2%2Fnextbike_le%2Fgbfs.json

and can confirm that vehicle_types.json is not marked as required anymore and consequently the feed is considered valid.

Thanks for the fix @tdelmas and the good work everyone!

[netlify]

✅ Deploy Preview for wizardly-lichterman-770f54 canceled.

Name	Link
🔨 Latest commit	274582f
🔍 Latest deploy log	https://app.netlify.com/sites/wizardly-lichterman-770f54/deploys/633d78323e927300076cd2e2

[netlify]

✅ Deploy Preview for unruffled-hugle-914373 ready!

Name	Link
🔨 Latest commit	274582f
🔍 Latest deploy log	https://app.netlify.com/sites/unruffled-hugle-914373/deploys/633d78323d1bab000979aff7
😎 Deploy Preview	https://deploy-preview-86--unruffled-hugle-914373.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.