fix: license_id AND license_url should be empty for default license #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at the spec today, and as part of this I was looking at the v3.0-RC fields for licensing - license_id and license_url.
Looking back at the original discussion for these fields in #182, I believe the intent here is that if in a v3.0-RC feed BOTH fields are left blank, then the feed falls under a default license (Creative Commons Universal Public Domain Dedication).
However, the draft spec currently uses
or
, which could be interpreted as if one of these fields is blank, then the default applies.This PR changes the language to use
and
instead ofor
, which I believe is the original intent of #182.