-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Add deep links for iOS, Android, and web apps #25
Merged
barbeau
merged 9 commits into
MobilityData:master
from
CUTR-at-USF:bike-station-purchase-url
Dec 5, 2019
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
979cfa2
Add purchase_url to free bikes and stations
barbeau c6eab6e
Include full purchase_url URL in GBFS station_information and free_bi…
barbeau 10e8e5d
Change from purchase_url to rental_url, better deep link description
barbeau 6eafdea
Merge branch 'master' into bike-station-purchase-url
barbeau 245ff6a
Merge branch 'master' into bike-station-purchase-url
barbeau b2434e2
Update to GBFS-DeepLinks-v2 proposal
barbeau d07aa7d
Add more references to examples and analytics section
barbeau 1a8aa9c
Remove "first click free" reference
barbeau 3e90af2
Add (beta) label to new fields
barbeau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lyft has some concerns with the "First Click Free" language - this would require some major re-architecture of our apps (I'm sure other providers would have similar issues) and isn't a super common scenario. This is currently marked as "should" - we will not be requiring providers to do this, correct?
For what it's worth Google has since moved away from requiring FCF.