-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove string field type from price field #352
Conversation
I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on December 9, 2021. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
+1 from Google Maps |
+1 from Ito World. |
+1 from Transit |
Entur supports this proposal |
+1 from nextbike |
Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
+1 from Spin. |
This vote has now closed, and it passes! Votes in favor: There were no votes against. We will tag and merge this into v3.0-RC2 in the coming weeks. |
What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.
price
field insystem_pricing_plans.json
allowed for both string and non-negative float field types.What is the proposal?
price
will now only allow for non-negative float field types.Is this a breaking change?
Which files are affected by this change?