Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove string field type from price field #352

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Conversation

josee-sabourin
Copy link
Contributor

What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.

price field in system_pricing_plans.json allowed for both string and non-negative float field types.

What is the proposal?

price will now only allow for non-negative float field types.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

  • system_pricing_plans.json

@josee-sabourin josee-sabourin added proposal:breaking v3.0-RC Candidate change for GBFS 3.0 (Major release) labels Aug 17, 2021
@mplsmitch
Copy link
Collaborator

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on December 9, 2021.

Please vote for or against the proposal, and include the organization for which you are voting in your comment.

Please note if you can commit to implementing the proposal.

@kanagy
Copy link

kanagy commented Nov 29, 2021

+1 from Google Maps

@richtaylor-ito
Copy link
Contributor

+1 from Ito World.

@cmonagle
Copy link
Contributor

+1 from Transit

@testower
Copy link
Contributor

testower commented Dec 6, 2021

Entur supports this proposal

@nbdh
Copy link
Contributor

nbdh commented Dec 6, 2021

+1 from nextbike

@heidiguenin
Copy link
Contributor

Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal.

@ncancelliere
Copy link

+1 from Spin.

@heidiguenin
Copy link
Contributor

This vote has now closed, and it passes!

Votes in favor:
Google Maps (consumer)
Ito World (producer)
Transit (consumer)
Entur (consumer)
nextbike (producer)
Spin (producer)

There were no votes against.
Thank you to everyone who took the time to review and to vote on this!

We will tag and merge this into v3.0-RC2 in the coming weeks.

@mplsmitch mplsmitch merged commit 15548f6 into master Jan 12, 2022
@josee-sabourin josee-sabourin deleted the pricing-number-fix branch March 13, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.0-RC Candidate change for GBFS 3.0 (Major release) Vote Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants