-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File requirements and Clarifying changes #384
Conversation
Changes SHOULS to MUSTs in File Requirements section, Renames fields describing parking capacity of stations by vehicle type, changes geofencing rules definition to apply to the intersection of polygons in stead of the union of polygons.
Adds HTTPS reqs to endpoints and deeplinks. Removes system_id from free_bike_status
Updates definition of system_id, SHOULD becomes MUST
I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on December 9, 2021. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
+1 from Ito World. |
Entur supports this proposal |
+1 from nextbike One remark on a phrasing detail:
It is obvious what is meant, but for me it seems that the other points in this list rather describe the content of the files, while the paragraph "File Distribution" rather contains the description of how these files are made available.
From a technical point of view it also sounds odd that a file uses a protocol. I suggest to rearrange and/or rephrase these two points. |
Thanks @nbdh - we'll get that cleaned up before merging! |
+1 from Google Maps |
Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
+1 from Spin |
This vote has now closed, and it passes! Votes in favor: There were no votes against. We'll update the documentation as discussed, and then we will tag and merge this into v3.0-RC2 in the coming weeks. |
moves reqs for use of HTTPS on endpoints under file distribution
What is the proposal?
This PR contains a number of breaking changes for v3.0 that are needed to correct inconsistencies and further clarify the specification.
system_id
changed from SHOULD to MUST, also adds HTTPS requirement for all endpoints and deeplinksrules
field definition ingeofencing_zones.json
has been changed per the discussion in Clarifying geofencing_zones.json language about intersections #361 to apply rules to the the intersection, not to the union of overlapping polygons. More substantial work ongeofencing_zones.json
will be coming in the future.system_id
fromfree_bike_status
as discussed in system_id and aggregated feeds #286 - it’s not possible to define multiple systems within a single feed so all vehicles in the feed share the samesystem_id
.Is this a breaking change?
Which files are affected by this change?