Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File requirements and Clarifying changes #384

Merged
merged 6 commits into from
Jan 17, 2022
Merged

Conversation

mplsmitch
Copy link
Collaborator

@mplsmitch mplsmitch commented Nov 2, 2021

What is the proposal?

This PR contains a number of breaking changes for v3.0 that are needed to correct inconsistencies and further clarify the specification.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

  • gbfs.md
    • station_information.json
    • free_bike_status.json

Mitch Vars added 2 commits November 1, 2021 17:29
Changes SHOULS to MUSTs in File Requirements section, Renames fields describing parking capacity of stations by vehicle type, changes geofencing rules definition  to apply to the intersection of polygons in stead of the union of polygons.
Adds HTTPS reqs to endpoints and deeplinks. Removes system_id from free_bike_status
@mplsmitch mplsmitch added proposal:breaking v3.0-RC Candidate change for GBFS 3.0 (Major release) labels Nov 2, 2021
Updates definition of system_id, SHOULD becomes MUST
@mplsmitch
Copy link
Collaborator Author

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on December 9, 2021.

Please vote for or against the proposal, and include the organization for which you are voting in your comment.

Please note if you can commit to implementing the proposal.

@richtaylor-ito
Copy link
Contributor

+1 from Ito World.

@testower
Copy link
Contributor

testower commented Dec 6, 2021

Entur supports this proposal

@nbdh
Copy link
Contributor

nbdh commented Dec 6, 2021

+1 from nextbike

One remark on a phrasing detail:

* All files MUST use HTTPS
* All deep links MUST use HTTPS

It is obvious what is meant, but for me it seems that the other points in this list rather describe the content of the files, while the paragraph "File Distribution" rather contains the description of how these files are made available.

Files are distributed as individual HTTP endpoints.

From a technical point of view it also sounds odd that a file uses a protocol.

I suggest to rearrange and/or rephrase these two points.

@heidiguenin
Copy link
Contributor

Thanks @nbdh - we'll get that cleaned up before merging!

@kanagy
Copy link

kanagy commented Dec 6, 2021

+1 from Google Maps

@heidiguenin
Copy link
Contributor

Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal.

@ncancelliere
Copy link

+1 from Spin

@heidiguenin
Copy link
Contributor

This vote has now closed, and it passes!

Votes in favor:
Ito World (producer)
Entur (consumer)
nextbike (producer)
Google Maps (consumer)
Spin (producer)

There were no votes against.
Thank you to everyone who took the time to review and to vote on this!

We'll update the documentation as discussed, and then we will tag and merge this into v3.0-RC2 in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.0-RC Candidate change for GBFS 3.0 (Major release) Vote Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants