-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to return_types field #400
Conversation
Changes definition and field type for return_type enum
renames return_type to return_constraint
I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on January 29, 2022. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
+1 From transit |
+1 From Google Maps, we don't ingest it yet but it definitely makes for a less ambiguous spec. |
+1 from Entur |
+1 from Spin |
This vote has now closed, and it passes! Votes in favor: |
Updated after modifications in MobilityData/gbfs#400
We’ve discovered an issue with a field that was added in v2.3RC and it's significant enough that we'd like to fix it before the v2.3RC2 and v3.0RC release candidates are completed. The issue is with the
return_type
field that describes constraints placed on the return of vehicles at the end of a rental. The field was defined as an array of enums which allowed multiple constraints to be placed on a vehicle. The problem is that the enums as defined were exclusive and not able to be combined, for example a vehicle can’t be both free floating and be required to be returned to a station. To fix this I’ve changed the field from an array of enums to a simple enum, and added an option for hybrid systems where vehicles can be returned to stations or free floating. I’ve also renamed the field fromreturn_type
toreturn_constraint
as was suggested in #329.We plan to call a vote on this proposal on January 18th. Please submit any feedback before then.