Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to return_types field #400

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Changes to return_types field #400

merged 4 commits into from
Jan 31, 2022

Conversation

mplsmitch
Copy link
Collaborator

We’ve discovered an issue with a field that was added in v2.3RC and it's significant enough that we'd like to fix it before the v2.3RC2 and v3.0RC release candidates are completed. The issue is with the return_type field that describes constraints placed on the return of vehicles at the end of a rental. The field was defined as an array of enums which allowed multiple constraints to be placed on a vehicle. The problem is that the enums as defined were exclusive and not able to be combined, for example a vehicle can’t be both free floating and be required to be returned to a station. To fix this I’ve changed the field from an array of enums to a simple enum, and added an option for hybrid systems where vehicles can be returned to stations or free floating. I’ve also renamed the field from return_type to return_constraint as was suggested in #329.

We plan to call a vote on this proposal on January 18th. Please submit any feedback before then.

Mitch Vars added 3 commits January 11, 2022 11:00
Changes definition and field type for return_type enum
renames return_type to return_constraint
@mplsmitch
Copy link
Collaborator Author

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on January 29, 2022.

Please vote for or against the proposal, and include the organization for which you are voting in your comment.

Please note if you can commit to implementing the proposal.

@cmonagle
Copy link
Contributor

+1 From transit

@kanagy
Copy link

kanagy commented Jan 19, 2022

+1 From Google Maps, we don't ingest it yet but it definitely makes for a less ambiguous spec.

@testower
Copy link
Contributor

+1 from Entur

@mattroeske
Copy link

+1 from Spin

@heidiguenin
Copy link
Contributor

This vote has now closed, and it passes!

Votes in favor:
Transit (consumer)
Google Maps (consumer)
Entur (consumer)
Spin (producer)

There were no votes against.
Thank you to everyone who took the time to review and to vote on this! We incorporate it into v2.3-RC2, which should be ready to go in the coming week.

@mplsmitch mplsmitch merged commit 498490f into master Jan 31, 2022
isabelle-dr added a commit to MobilityData/gbfs-json-schema that referenced this pull request Mar 10, 2022
Updated after modifications in MobilityData/gbfs#400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants