Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing auto-discovery URL to direct download URL #62

Closed
emmambd opened this issue Mar 8, 2022 · 2 comments · Fixed by #70 or #84
Closed

Changing auto-discovery URL to direct download URL #62

emmambd opened this issue Mar 8, 2022 · 2 comments · Fixed by #70 or #84
Assignees
Labels

Comments

@emmambd
Copy link
Contributor

emmambd commented Mar 8, 2022

What problem are we trying to solve?
We want to change the auto-discovery URL because "discovery" is not a commonly used term or convention in GTFS. (The original term was inspired by GBFS' systems.csv).

We intend to change this to "direct download URL" so it's clear that this link downloads a source.

How will we know when this is done?

All references to auto-discovery URL removed in the JSON schema, operations, and CSV export, and direct download URL used instead.

@emmambd emmambd changed the title Changing auto-discovery URL to Source Download URL Changing auto-discovery URL to source download URL Mar 8, 2022
@emmambd emmambd added the V1 label Mar 8, 2022
@emmambd emmambd changed the title Changing auto-discovery URL to source download URL Changing auto-discovery URL to direct download URL Mar 9, 2022
@e-lo
Copy link
Contributor

e-lo commented Mar 9, 2022

I like the consolidation to a single URL to find the data - wondering if should just be URL? and then the description could be "URL which downloads the data".

@maximearmstrong
Copy link
Contributor

@e-lo I saw your comment after merging the PR yesterday. The direct_download is nested under urls. We now have {"urls": {"direct_download": "...", "latest": "...", "license": "..."}}. Do you think that using URL instead of direct_download would be better in that context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment