-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Realtime schema updated in README #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments in-line before approval.
I strongly suggest that we add a Type
column right after the Field
column. We can use the types described at gtfs.org.
We will also need the JSON
type in some cases. For example, the type for a realtime URL would be JSON
, and it would follow its own data structure, like GTFS Realtime URL data structure
, which can be referenced in the Description
column for the row. You could define this in another table in a subsection with direct_download_url
, license_url
, etc. The [Transitfeeds] API (https://transitfeeds.com/api/swagger/) follows this idea and works well.
I think it would make the data structure clearer and also avoid duplicates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @emmambd, some comments in-line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to consider before modifying the JSON schema :) Let's discuss them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change to make :) Aside that, LGTM!
Co-authored-by: Maxime Armstrong <46797220+maximearmstrong@users.noreply.github.com>
@maximearmstrong Thanks for the update - should be set now! |
Based on the discussion in issue #36, this is the updated schema that will be shared in the README.