Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Add 403 error fallback handler for dataset downloads #702

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

AlfredNwolisa
Copy link
Collaborator

@AlfredNwolisa AlfredNwolisa commented Feb 3, 2025

  • Implemented fallback mechanism with browser-like headers for 403 errors
  • Added HTTPError to imports from requests.exceptions
  • Added urlparse for URL parsing in fallback logic
  • Included test cases for 403 fallback success and failure scenarios

- Implement fallback mechanism with browser-like headers for 403 errors
- Add HTTPError to imports from requests.exceptions
- Add urlparse for URL parsing in fallback logic
- Include comprehensive test cases for 403 fallback success and failure scenarios
@AlfredNwolisa AlfredNwolisa linked an issue Feb 3, 2025 that may be closed by this pull request
@AlfredNwolisa AlfredNwolisa changed the title feat: Added 403 error fallback handler for dataset downloads bug: Added 403 error fallback handler for dataset downloads Feb 3, 2025
@AlfredNwolisa AlfredNwolisa changed the title bug: Added 403 error fallback handler for dataset downloads bug: Add 403 error fallback handler for dataset downloads Feb 3, 2025
…ck handling for HTTP 403 errors. Added `FALLBACK_HEADERS` to `constants.py` and updated `helpers.py` to utilize these headers for retries.
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlfredNwolisa AlfredNwolisa merged commit 935cd16 into main Feb 5, 2025
9 checks passed
@AlfredNwolisa AlfredNwolisa deleted the helpers_403_error_handler branch February 5, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: 403 errors when validating a URL
2 participants