official_updated_at added

Co-authored-by: Jingsi Lu <jingsi@mobilitydata.org>
MobilityData · Jan 13, 2025 · 0de4b02 · 0de4b02
1 parent 2a715c0
commit 0de4b02
Show file tree

Hide file tree

Showing 9 changed files with 141 additions and 112 deletions.
diff --git a/api/src/feeds/impl/models/basic_feed_impl.py b/api/src/feeds/impl/models/basic_feed_impl.py
@@ -23,14 +23,12 @@ class Config:
     def from_orm(cls, feed: Feed | None, _=None) -> BasicFeed | None:
         if not feed:
             return None
-        latest_official_status = None
-        if len(feed.officialstatushistories) > 0:
-            latest_official_status = max(feed.officialstatushistories, key=lambda x: x.timestamp).is_official
         return cls(
             id=feed.stable_id,
             data_type=feed.data_type,
             status=feed.status,
-            official=latest_official_status,
+            official=feed.official,
+            official_updated_at=feed.official_updated_at,
             created_at=feed.created_at,
             external_ids=sorted(
                 [ExternalIdImpl.from_orm(item) for item in feed.externalids], key=lambda x: x.external_id

diff --git a/docs/DatabaseCatalogAPI.yaml b/docs/DatabaseCatalogAPI.yaml
@@ -362,6 +362,12 @@ components:
                 Official feeds are provided by the transit agency or a trusted source.
             type: boolean
             example: true
+        official_updated_at:
+            description: >
+                The date and time the official status was last updated, in ISO 8601 date-time format.
+            type: string
+            example: 2023-07-10T22:06:00Z
+            format: date-time
         external_ids:
           $ref: "#/components/schemas/ExternalIds"
         provider:

diff --git a/liquibase/changelog.xml b/liquibase/changelog.xml
@@ -33,4 +33,5 @@
     <include file="changes/feat_741.sql" relativeToChangelogFile="true"/>
     <include file="changes/feat_794.sql" relativeToChangelogFile="true"/>
     <include file="changes/feat_794_2.sql" relativeToChangelogFile="true"/>
+    <include file="changes/feat_871.sql" relativeToChangelogFile="true"/>
 </databaseChangeLog>
diff --git a/liquibase/changes/feat_871.sql b/liquibase/changes/feat_871.sql
@@ -0,0 +1 @@
+ALTER TABLE Feed ADD COLUMN official_updated_at TIMESTAMP DEFAULT NULL;
diff --git a/liquibase/changes/official_tag_update.sql b/liquibase/changes/official_tag_update.sql
@@ -1,7 +1,9 @@
 -- Query to update official tag for feeds with contact email in the feed table where the source is mdb
 
 UPDATE public.feed f
-SET official = TRUE
+SET 
+  official = TRUE
+  official_updated_at = NOW()
 FROM public.externalid e
 WHERE f.id = e.feed_id
   AND f.feed_contact_email LIKE '%@%'

diff --git a/web-app/public/locales/en/feeds.json b/web-app/public/locales/en/feeds.json
@@ -93,5 +93,6 @@
   "officialFeedTooltipShort": "Verified feed: Confirmed by the transit provider or the Mobility Database team for rider use.",
   "seeDetailPageProviders": "See detail page to view {providersCount} others",
   "openFullQualityReport": "Open Full Quality Report",
-  "qualityReportUpdated": "Quality report updated"
+  "qualityReportUpdated": "Quality report updated",
+  "officialFeedUpdated": "Official verification updated"
 }
diff --git a/web-app/src/app/screens/Feed/DataQualitySummary.tsx b/web-app/src/app/screens/Feed/DataQualitySummary.tsx
@@ -24,102 +24,106 @@ export default function DataQualitySummary({
         latestDataset.validation_report === null) && (
         <WarningContentBox>{t('errorLoadingQualityReport')}</WarningContentBox>
       )}
-      {latestDataset?.validation_report !== undefined &&
-        latestDataset.validation_report !== null && (
-          <Box sx={{ display: 'flex', gap: 1 }}>
-            {isOfficialFeed && (
-              <Tooltip title={t('officialFeedTooltip')} placement='top'>
-                <Chip
-                  sx={verificationBadgeStyle}
-                  icon={<VerifiedIcon sx={{ fill: 'white' }}></VerifiedIcon>}
-                  label={t('officialFeed')}
-                ></Chip>
-              </Tooltip>
-            )}
+      <Box sx={{ display: 'flex', gap: 1 }}>
+        {isOfficialFeed && (
+          <Tooltip title={t('officialFeedTooltip')} placement='top'>
             <Chip
-              data-testid='error-count'
-              clickable
-              component='a'
-              href={latestDataset?.validation_report?.url_html}
-              target='_blank'
-              rel='noopener noreferrer'
-              icon={
-                latestDataset?.validation_report?.unique_error_count !==
-                  undefined &&
-                latestDataset?.validation_report?.unique_error_count > 0 ? (
-                  <ReportOutlined />
-                ) : (
-                  <CheckCircle />
-                )
-              }
-              label={
-                latestDataset?.validation_report?.unique_error_count !==
-                  undefined &&
-                latestDataset?.validation_report?.unique_error_count > 0
-                  ? `${latestDataset?.validation_report
-                      ?.unique_error_count} ${t('common:feedback.errors')}`
-                  : t('common:feedback.noErrors')
-              }
-              color={
-                latestDataset?.validation_report?.unique_error_count !==
-                  undefined &&
-                latestDataset?.validation_report?.unique_error_count > 0
-                  ? 'error'
-                  : 'success'
-              }
-              variant='outlined'
-            />
+              sx={verificationBadgeStyle}
+              icon={<VerifiedIcon sx={{ fill: 'white' }}></VerifiedIcon>}
+              label={t('officialFeed')}
+            ></Chip>
+          </Tooltip>
+        )}
+        {latestDataset?.validation_report !== undefined &&
+          latestDataset.validation_report !== null && (
+            <>
+              <Chip
+                data-testid='error-count'
+                clickable
+                component='a'
+                href={latestDataset?.validation_report?.url_html}
+                target='_blank'
+                rel='noopener noreferrer'
+                icon={
+                  latestDataset?.validation_report?.unique_error_count !==
+                    undefined &&
+                  latestDataset?.validation_report?.unique_error_count > 0 ? (
+                    <ReportOutlined />
+                  ) : (
+                    <CheckCircle />
+                  )
+                }
+                label={
+                  latestDataset?.validation_report?.unique_error_count !==
+                    undefined &&
+                  latestDataset?.validation_report?.unique_error_count > 0
+                    ? `${latestDataset?.validation_report
+                        ?.unique_error_count} ${t('common:feedback.errors')}`
+                    : t('common:feedback.noErrors')
+                }
+                color={
+                  latestDataset?.validation_report?.unique_error_count !==
+                    undefined &&
+                  latestDataset?.validation_report?.unique_error_count > 0
+                    ? 'error'
+                    : 'success'
+                }
+                variant='outlined'
+              />
 
-            <Chip
-              data-testid='warning-count'
-              clickable
-              component='a'
-              href={latestDataset?.validation_report?.url_html}
-              target='_blank'
-              rel='noopener noreferrer'
-              icon={
-                latestDataset?.validation_report?.unique_warning_count !==
-                  undefined &&
-                latestDataset?.validation_report?.unique_warning_count > 0 ? (
-                  <ReportOutlined />
-                ) : (
-                  <CheckCircle />
-                )
-              }
-              label={
-                latestDataset?.validation_report?.unique_warning_count !==
-                  undefined &&
-                latestDataset?.validation_report?.unique_warning_count > 0
-                  ? `${latestDataset?.validation_report
-                      ?.unique_warning_count} ${t('common:feedback.warnings')}`
-                  : t('common:feedback.no_warnings')
-              }
-              color={
-                latestDataset?.validation_report?.unique_warning_count !==
-                  undefined &&
-                latestDataset?.validation_report?.unique_warning_count > 0
-                  ? 'warning'
-                  : 'success'
-              }
-              variant='outlined'
-            />
+              <Chip
+                data-testid='warning-count'
+                clickable
+                component='a'
+                href={latestDataset?.validation_report?.url_html}
+                target='_blank'
+                rel='noopener noreferrer'
+                icon={
+                  latestDataset?.validation_report?.unique_warning_count !==
+                    undefined &&
+                  latestDataset?.validation_report?.unique_warning_count > 0 ? (
+                    <ReportOutlined />
+                  ) : (
+                    <CheckCircle />
+                  )
+                }
+                label={
+                  latestDataset?.validation_report?.unique_warning_count !==
+                    undefined &&
+                  latestDataset?.validation_report?.unique_warning_count > 0
+                    ? `${latestDataset?.validation_report
+                        ?.unique_warning_count} ${t(
+                        'common:feedback.warnings',
+                      )}`
+                    : t('common:feedback.no_warnings')
+                }
+                color={
+                  latestDataset?.validation_report?.unique_warning_count !==
+                    undefined &&
+                  latestDataset?.validation_report?.unique_warning_count > 0
+                    ? 'warning'
+                    : 'success'
+                }
+                variant='outlined'
+              />
 
-            <Chip
-              data-testid='info-count'
-              icon={<InfoOutlinedIcon />}
-              clickable
-              component='a'
-              href={latestDataset?.validation_report?.url_html}
-              target='_blank'
-              rel='noopener noreferrer'
-              label={`${
-                latestDataset?.validation_report?.unique_info_count ?? '0'
-              } ${t('common:feedback.infoNotices')}`}
-              color='primary'
-              variant='outlined'
-            />
-          </Box>
-        )}
+              <Chip
+                data-testid='info-count'
+                icon={<InfoOutlinedIcon />}
+                clickable
+                component='a'
+                href={latestDataset?.validation_report?.url_html}
+                target='_blank'
+                rel='noopener noreferrer'
+                label={`${
+                  latestDataset?.validation_report?.unique_info_count ?? '0'
+                } ${t('common:feedback.infoNotices')}`}
+                color='primary'
+                variant='outlined'
+              />
+            </>
+          )}
+      </Box>
     </Box>
   );
 }
diff --git a/web-app/src/app/screens/Feed/index.tsx b/web-app/src/app/screens/Feed/index.tsx
@@ -423,19 +423,28 @@ export default function Feed(): React.ReactElement {
       )}
       <Box>
         {latestDataset?.validation_report?.validated_at != undefined && (
-          <>
-            <Typography
-              data-testid='last-updated'
-              variant={'caption'}
-              width={'100%'}
-              component={'div'}
-            >
-              {`${t('qualityReportUpdated')}: ${new Date(
-                latestDataset.validation_report.validated_at,
-              ).toDateString()}`}
-            </Typography>
-            {/* TODO: add timestamp for badge verify */}
-          </>
+          <Typography
+            data-testid='last-updated'
+            variant={'caption'}
+            width={'100%'}
+            component={'div'}
+          >
+            {`${t('qualityReportUpdated')}: ${new Date(
+              latestDataset.validation_report.validated_at,
+            ).toDateString()}`}
+          </Typography>
+        )}
+        {feed?.official_updated_at != undefined && (
+          <Typography
+            data-testid='last-updated'
+            variant={'caption'}
+            width={'100%'}
+            component={'div'}
+          >
+            {`${t('officialFeedUpdated')}: ${new Date(
+              feed?.official_updated_at,
+            ).toDateString()}`}
+          </Typography>
         )}
       </Box>
 

diff --git a/web-app/src/app/services/feeds/types.ts b/web-app/src/app/services/feeds/types.ts
@@ -144,6 +144,13 @@ export interface components {
        * @example true
        */
       official?: boolean;
+      /**
+       * Format: date-time
+       * @description The date and time the official status was last updated, in ISO 8601 date-time format.
+       *
+       * @example "2023-07-10T22:06:00.000Z"
+       */
+      official_updated_at?: string;
       external_ids?: components['schemas']['ExternalIds'];
       /**
        * @description A commonly used name for the transit provider included in the feed.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		ALTER TABLE Feed ADD COLUMN official_updated_at TIMESTAMP DEFAULT NULL;